Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B #469: Fix service crashes #509

Merged
merged 2 commits into from
Dec 13, 2023
Merged

B #469: Fix service crashes #509

merged 2 commits into from
Dec 13, 2023

Conversation

sk4zuzu
Copy link
Collaborator

@sk4zuzu sk4zuzu commented Dec 8, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

  • Correctly parse network IDs.
  • Correctly handle the "recover --delete" cleanup.

References

#469

New or Affected Resource(s)

  • opennebula_service

Checklist

  • I have created an issue and I have mentioned it in References
  • My code follows the style guidelines of this project (use go fmt)
  • My changes generate no new warnings or errors
  • I have updated the unit tests and they pass succesfuly
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (if needed)
  • I have updated the changelog file

- correctly parse network IDs
- correctly handle the "recover --delete" cleanup
Use ParseInt instead of ParseUint (fix)
@treywelsh treywelsh merged commit fd781c2 into master Dec 13, 2023
7 checks passed
@treywelsh treywelsh linked an issue Dec 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opennebula_service: Provider panics after creation timeout
3 participants